Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "change dice" on client #70 #89

Merged
merged 5 commits into from
Oct 6, 2024

Conversation

anonfedora
Copy link
Contributor

@anonfedora anonfedora commented Oct 3, 2024

Description

Detailed description of proposed changes

Related Issue(s)

Closes #70

Checklist:

  • Read the contributing docs (if this is your first contribution)

  • Verified this is not a duplicate of any existing pull request

  • Performed a self-review of the code

  • Rebased to the last commit of the target branch (or merged it into my branch)

  • Linked the issues which this PR resolves

  • Documented the changes in code (API docs will be generated automatically)

@0xibs 0xibs requested a review from vibenedict October 3, 2024 12:12
@0xibs 0xibs self-requested a review October 4, 2024 12:05
Copy link
Collaborator

@0xibs 0xibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please fix failing client CI:
    image
  • Also include the issue number this PR is closing

anonfedora added a commit to anonfedora/starkludo that referenced this pull request Oct 4, 2024
@0xibs 0xibs self-requested a review October 6, 2024 08:14
Copy link
Collaborator

@0xibs 0xibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xibs 0xibs merged commit 3cf0417 into sivicstudio:dev Oct 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "change dice" on client
2 participants